lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 039/199] nfs_write_end(): fix handling of short copies
    3.2.87-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Al Viro <viro@zeniv.linux.org.uk>

    commit c0cf3ef5e0f47e385920450b245d22bead93e7ad upstream.

    What matters when deciding if we should make a page uptodate is
    not how much we _wanted_ to copy, but how much we actually have
    copied. As it is, on architectures that do not zero tail on
    short copy we can leave uninitialized data in page marked uptodate.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/nfs/file.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfs/file.c
    +++ b/fs/nfs/file.c
    @@ -397,7 +397,7 @@ static int nfs_write_end(struct file *fi
    */
    if (!PageUptodate(page)) {
    unsigned pglen = nfs_page_length(page);
    - unsigned end = offset + len;
    + unsigned end = offset + copied;

    if (pglen == 0) {
    zero_user_segments(page, 0, offset,
    \
     
     \ /
      Last update: 2017-03-10 14:15    [W:4.107 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site