lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 090/199] ata: sata_mv:- Handle return value of devm_ioremap.
    3.2.87-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arvind Yadav <arvind.yadav.cs@gmail.com>

    commit 064c3db9c564cc5be514ac21fb4aa26cc33db746 upstream.

    Here, If devm_ioremap will fail. It will return NULL.
    Then hpriv->base = NULL - 0x20000; Kernel can run into
    a NULL-pointer dereference. This error check will avoid
    NULL pointer dereference.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/ata/sata_mv.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/ata/sata_mv.c
    +++ b/drivers/ata/sata_mv.c
    @@ -4059,6 +4059,9 @@ static int mv_platform_probe(struct plat
    host->iomap = NULL;
    hpriv->base = devm_ioremap(&pdev->dev, res->start,
    resource_size(res));
    + if (!hpriv->base)
    + return -ENOMEM;
    +
    hpriv->base -= SATAHC0_REG_BASE;

    #if defined(CONFIG_HAVE_CLK)
    \
     
     \ /
      Last update: 2017-03-10 14:03    [W:5.582 / U:0.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site