lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 027/199] ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()
    3.2.87-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 4763601a56f155ddf94ef35fc2c41504a2de15f5 upstream.

    The function returns -EINVAL even if it builds the stream properly.
    The bogus error code sneaked in during the code refactoring, but it
    wasn't noticed until now since the returned error code itself is
    ignored in anyway. Kill it here, but there is no behavior change by
    this patch, obviously.

    Fixes: e5779998bf8b ('ALSA: usb-audio: refactor code')
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/usb/card.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/sound/usb/card.c
    +++ b/sound/usb/card.c
    @@ -207,7 +207,6 @@ static int snd_usb_create_stream(struct
    if (! snd_usb_parse_audio_interface(chip, interface)) {
    usb_set_interface(dev, interface, 0); /* reset the current interface */
    usb_driver_claim_interface(&usb_audio_driver, iface, (void *)-1L);
    - return -EINVAL;
    }

    return 0;
    \
     
     \ /
      Last update: 2017-03-10 13:40    [W:2.860 / U:2.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site