lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 001/370] staging: iio: ad7606: fix improper setting of oversampling pins
    3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eva Rachel Retuya <eraretuya@gmail.com>

    commit b321a38d2407c7e425c54bc09be909a34e49f740 upstream.

    The oversampling ratio is controlled using the oversampling pins,
    OS [2:0] with OS2 being the MSB control bit, and OS0 the LSB control
    bit.

    The gpio connected to the OS2 pin is not being set correctly, only OS0
    and OS1 pins are being set. Fix the typo to allow proper control of the
    oversampling pins.

    Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
    Fixes: b9618c0 ("staging: IIO: ADC: New driver for AD7606/AD7606-6/AD7606-4")
    Acked-by: Lars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: Jonathan Cameron <jic23@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/staging/iio/adc/ad7606_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/iio/adc/ad7606_core.c
    +++ b/drivers/staging/iio/adc/ad7606_core.c
    @@ -186,7 +186,7 @@ static ssize_t ad7606_store_oversampling
    mutex_lock(&indio_dev->mlock);
    gpio_set_value(st->pdata->gpio_os0, (ret >> 0) & 1);
    gpio_set_value(st->pdata->gpio_os1, (ret >> 1) & 1);
    - gpio_set_value(st->pdata->gpio_os1, (ret >> 2) & 1);
    + gpio_set_value(st->pdata->gpio_os2, (ret >> 2) & 1);
    st->oversampling = lval;
    mutex_unlock(&indio_dev->mlock);

    \
     
     \ /
      Last update: 2017-03-10 12:52    [W:4.797 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site