lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 41/91] jbd2: dont leak modified metadata buffers on an aborted journal
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit e112666b4959b25a8552d63bc564e1059be703e8 upstream.

    If the journal has been aborted, we shouldn't mark the underlying
    buffer head as dirty, since that will cause the metadata block to get
    modified. And if the journal has been aborted, we shouldn't allow
    this since it will almost certainly lead to a corrupted file system.

    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/jbd2/transaction.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/jbd2/transaction.c
    +++ b/fs/jbd2/transaction.c
    @@ -1876,7 +1876,9 @@ static void __jbd2_journal_temp_unlink_b

    __blist_del_buffer(list, jh);
    jh->b_jlist = BJ_None;
    - if (test_clear_buffer_jbddirty(bh))
    + if (transaction && is_journal_aborted(transaction->t_journal))
    + clear_buffer_jbddirty(bh);
    + else if (test_clear_buffer_jbddirty(bh))
    mark_buffer_dirty(bh); /* Expose it to the VM */
    }


    \
     
     \ /
      Last update: 2017-03-10 12:51    [W:4.837 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site