Messages in this thread | | | From | "Dilger, Andreas" <> | Subject | Re: [PATCH] Minor coding guideline Fix in lusture module | Date | Fri, 10 Mar 2017 05:25:22 +0000 |
| |
On Mar 9, 2017, at 05:22, Pushkar Jambhlekar <pushkar.iit@gmail.com> wrote: > Subject: Minor coding guideline Fix in lusture module
I suspect the patchbot is unhappy with the subject line not containing anything useful, and not containing the subsystem name. Something like:
staging/lustre/llite: replace "unsigned" with "unsigned int"
> Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
Remove double space, and reference function names like vvp_pgcache_id().
> Checkpath.pl passed.
"checkpatch.pl"
Cheers, Andreas
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com> > --- > drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c > index 12c129f7e..8d78755 100644 > --- a/drivers/staging/lustre/lustre/llite/vvp_dev.c > +++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c > @@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb) > #define PGC_DEPTH_SHIFT (32) > > struct vvp_pgcache_id { > - unsigned vpi_bucket; > - unsigned vpi_depth; > - uint32_t vpi_index; > - > - unsigned vpi_curdep; > + unsigned int vpi_bucket; > + unsigned int vpi_depth; > + uint32_t vpi_index; > + unsigned int vpi_curdep; > struct lu_object_header *vpi_obj; > }; > > -- > 2.7.4 >
Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation
| |