lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 025/370] regulator: stw481x-vmmc: fix ages old enable error
    3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Linus Walleij <linus.walleij@linaro.org>

    commit 295070e9aa015abb9b92cccfbb1e43954e938133 upstream.

    The regulator has never been properly enabled, it has been
    dormant all the time. It's strange that MMC was working
    at all, but it likely worked by the signals going through
    the levelshifter and reaching the card anyways.

    Fixes: 3615a34ea1a6 ("regulator: add STw481x VMMC driver")
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/regulator/stw481x-vmmc.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/regulator/stw481x-vmmc.c
    +++ b/drivers/regulator/stw481x-vmmc.c
    @@ -47,7 +47,8 @@ static struct regulator_desc vmmc_regula
    .volt_table = stw481x_vmmc_voltages,
    .enable_time = 200, /* FIXME: look this up */
    .enable_reg = STW_CONF1,
    - .enable_mask = STW_CONF1_PDN_VMMC,
    + .enable_mask = STW_CONF1_PDN_VMMC | STW_CONF1_MMC_LS_STATUS,
    + .enable_val = STW_CONF1_PDN_VMMC,
    .vsel_reg = STW_CONF1,
    .vsel_mask = STW_CONF1_VMMC_MASK,
    };
    \
     
     \ /
      Last update: 2017-03-10 15:29    [W:2.082 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site