lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 174/370] USB: serial: ti_usb_3410_5052: fix NULL-deref at open
    3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit ef079936d3cd09e63612834fe2698eeada0d8e3f upstream.

    Fix NULL-pointer dereference in open() should a malicious device lack
    the expected endpoints:

    Unable to handle kernel NULL pointer dereference at virtual address 00000030
    ..
    [<bf06a6b0>] (ti_open [ti_usb_3410_5052]) from [<bf02e118>] (serial_port_activate+0x68/0x98 [usbserial])

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/ti_usb_3410_5052.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/drivers/usb/serial/ti_usb_3410_5052.c
    +++ b/drivers/usb/serial/ti_usb_3410_5052.c
    @@ -339,6 +339,13 @@ static int ti_startup(struct usb_serial
    goto free_tdev;
    }

    + if (serial->num_bulk_in < serial->num_ports ||
    + serial->num_bulk_out < serial->num_ports) {
    + dev_err(&serial->interface->dev, "missing endpoints\n");
    + status = -ENODEV;
    + goto free_tdev;
    + }
    +
    return 0;

    free_tdev:
    \
     
     \ /
      Last update: 2017-03-10 15:02    [W:4.126 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site