lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 217/370] mmc: mxs-mmc: Fix additional cycles after transmission stop
    3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stefan Wahren <stefan.wahren@i2se.com>

    commit 01167c7b9cbf099c69fe411a228e4e9c7104e123 upstream.

    According to the code the intention is to append 8 SCK cycles
    instead of 4 at end of a MMC_STOP_TRANSMISSION command. But this
    will never happened because it's an AC command not an ADTC command.
    So fix this by moving the statement into the right function.

    Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
    Fixes: e4243f13d10e (mmc: mxs-mmc: add mmc host driver for i.MX23/28)
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/mmc/host/mxs-mmc.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/mmc/host/mxs-mmc.c
    +++ b/drivers/mmc/host/mxs-mmc.c
    @@ -308,6 +308,9 @@ static void mxs_mmc_ac(struct mxs_mmc_ho
    cmd0 = BF_SSP(cmd->opcode, CMD0_CMD);
    cmd1 = cmd->arg;

    + if (cmd->opcode == MMC_STOP_TRANSMISSION)
    + cmd0 |= BM_SSP_CMD0_APPEND_8CYC;
    +
    if (host->sdio_irq_en) {
    ctrl0 |= BM_SSP_CTRL0_SDIO_IRQ_CHECK;
    cmd0 |= BM_SSP_CMD0_CONT_CLKING_EN | BM_SSP_CMD0_SLOW_CLKING_EN;
    @@ -416,8 +419,7 @@ static void mxs_mmc_adtc(struct mxs_mmc_
    ssp->base + HW_SSP_BLOCK_SIZE);
    }

    - if ((cmd->opcode == MMC_STOP_TRANSMISSION) ||
    - (cmd->opcode == SD_IO_RW_EXTENDED))
    + if (cmd->opcode == SD_IO_RW_EXTENDED)
    cmd0 |= BM_SSP_CMD0_APPEND_8CYC;

    cmd1 = cmd->arg;
    \
     
     \ /
      Last update: 2017-03-10 14:55    [W:2.042 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site