lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 111/370] IB/multicast: Check ib_find_pkey() return value
    3.16.42-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bart Van Assche <bart.vanassche@sandisk.com>

    commit d3a2418ee36a59bc02e9d454723f3175dcf4bfd9 upstream.

    This patch avoids that Coverity complains about not checking the
    ib_find_pkey() return value.

    Fixes: commit 547af76521b3 ("IB/multicast: Report errors on multicast groups if P_key changes")
    Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
    Cc: Sean Hefty <sean.hefty@intel.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/infiniband/core/multicast.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    --- a/drivers/infiniband/core/multicast.c
    +++ b/drivers/infiniband/core/multicast.c
    @@ -516,8 +516,11 @@ static void join_handler(int status, str
    if (status)
    process_join_error(group, status);
    else {
    - ib_find_pkey(group->port->dev->device, group->port->port_num,
    - be16_to_cpu(rec->pkey), &pkey_index);
    +
    + if (ib_find_pkey(group->port->dev->device,
    + group->port->port_num, be16_to_cpu(rec->pkey),
    + &pkey_index))
    + pkey_index = MCAST_INVALID_PKEY_INDEX;

    spin_lock_irq(&group->port->lock);
    group->rec = *rec;
    \
     
     \ /
      Last update: 2017-03-10 14:55    [W:4.461 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site