lkml.org 
[lkml]   [2017]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 021/167] spi: s3c64xx: fix inconsistency between binding and driver
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andi Shyti <andi.shyti@samsung.com>

    commit 379f831a927817c130a62e3ca0082ae685557324 upstream.

    Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS
    line is not connected") introduced an inconsistency between the
    binding, where the disconnected CS line was marked as
    'no-cs-readback', and the driver.

    The driver is erroneously checking for that attribute with
    property name of 'broken-cs'.

    Check for 'no-cs-readback' in the driver as well.

    Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected")
    Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
    Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-s3c64xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/spi/spi-s3c64xx.c
    +++ b/drivers/spi/spi-s3c64xx.c
    @@ -996,7 +996,7 @@ static struct s3c64xx_spi_info *s3c64xx_
    sci->num_cs = temp;
    }

    - sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs");
    + sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback");

    return sci;
    }

    \
     
     \ /
      Last update: 2017-03-10 10:31    [W:5.152 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site