Messages in this thread | | | Date | Wed, 1 Mar 2017 08:51:22 +0100 | From | Greg KH <> | Subject | Re: [PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info |
| |
On Tue, Feb 28, 2017 at 01:57:53PM +0530, Pranay Kr. Srivastava wrote: > This patch makes spk_set_key_info return -EINVAL > in case of failure instead of returning 4 different > values for the type of error that occurred. > > Print the offending values instead as debug message. > > Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com> > --- > drivers/staging/speakup/main.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-)
Please fix up your subject line to contain the subsystem and driver it is modifying. For example, this message should read: Subject: staging: speakup: return same error value from spk_set_key_info
Same thing goes for all 3 messages in this series.
Please fix up, keep the Ack, and resend.
thanks,
greg k-h
| |