lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] net: sched: make default fifo qdiscs appear in the dump
From
From: Jiri Kosina <jikos@kernel.org>
Date: Sat, 25 Feb 2017 22:29:09 +0100 (CET)

> @@ -1066,6 +1066,7 @@ hfsc_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
> &pfifo_qdisc_ops, classid);
> if (cl->qdisc == NULL)
> cl->qdisc = &noop_qdisc;
> + qdisc_hash_add(cl->qdisc, true);
> INIT_LIST_HEAD(&cl->children);
> cl->vt_tree = RB_ROOT;
> cl->cf_tree = RB_ROOT;
> @@ -1425,6 +1426,7 @@ hfsc_init_qdisc(struct Qdisc *sch, struct nlattr *opt)
> sch->handle);
> if (q->root.qdisc == NULL)
> q->root.qdisc = &noop_qdisc;
> + qdisc_hash_add(q->root.qdisc, true);
> INIT_LIST_HEAD(&q->root.children);
> q->root.vt_tree = RB_ROOT;
> q->root.cf_tree = RB_ROOT;

I'm not so sure it is legal is potentially pass &noop_qdisc into qdisc_hash_add().

\
 
 \ /
  Last update: 2017-03-01 23:22    [W:0.051 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site