Messages in this thread | | | Date | Wed, 1 Mar 2017 17:37:32 +0100 | From | Radim Krčmář <> | Subject | Re: [PATCH v2 1/5] KVM: rename API for requests to match bit operations |
| |
2017-02-27 10:54+0100, David Hildenbrand: > Am 24.02.2017 um 20:49 schrieb Radim Krčmář: >> kvm_make_request was a wrapper that added barriers to set_bit and >> kvm_check_request did the same for test_bit and check_bit, but the name >> was not very obvious. >> >> The renaming: >> kvm_request_set <- kvm_make_request >> kvm_request_test_and_clear <- kvm_check_request >> > > What about kvm_req_set() / kvm_req_test_and_clear() > Matches the request bit definitions (KVM_REQ_*) and saves a couple of > characters.
Good point. I prefer to avoid abbreviations, but can be easily convinced on this.
> Anyhow > > Reviewed-by: David Hildenbrand <david@redhat.com>
I'll do nothing for now as it would just spin another round of reviews.
Thanks.
| |