lkml.org 
[lkml]   [2017]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code
Date
Juergen Gross <jgross@suse.com> writes:

> On 24/02/17 17:14, Vitaly Kuznetsov wrote:
>> Introduce CONFIG_XEN_PV config option and split enlighten.c into
>> 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to
>> not break the build and not make the patch even bigger.
>>
>> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support
>> future xen_smp_intr_init() split.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Could you please split pure code movement and functional changes into
> different patches? This would make review much easier.
>

It's a bit hard with this series to make patches smaller and not break
the build ... :-(

> So 1 patch to split up enlightenment.c and at least one patch for the
> rest of the changes (Kconfig, splitting of x86_hyper_xen, ...).

This sounds doable, I'll try!

--
Vitaly

\
 
 \ /
  Last update: 2017-03-01 10:53    [W:2.096 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site