lkml.org 
[lkml]   [2017]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver
From
Date
On 02/08/2017 09:16 PM, Andy Shevchenko wrote:
> On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote:
>> Should I keep my inline {clr,set}_bit_in_byte()
>> functions an use BIT() in there, or delete them and use BIT()
>> directly
>> in usb251xb_get_ofdata() ?
>
> Does it make any sense?
>
> Even just name of your function is longer than what it substitutes.

Well, you're right :-)
So I'll change that for v5.

Thanks!

\
 
 \ /
  Last update: 2017-02-09 09:51    [W:0.073 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site