Messages in this thread | | | Date | Thu, 9 Feb 2017 18:11:15 +0100 | From | Daniel Vetter <> | Subject | Re: [PATCH] drm/vc4: Drop debug print at boot with DPI enabled. |
| |
On Wed, Feb 08, 2017 at 12:47:01PM -0800, Eric Anholt wrote: > Unlike the other encoders in the driver, I've also dropped the debug > dump function. There's only really one register to this device, and > we have the debugfs reg entry still. > > Signed-off-by: Eric Anholt <eric@anholt.net>
Yeah, dmesg spew by default isn't cool. Btw if you ever want to have fancy debug printers, there's drm_printer, which allows you to spam both dmesg and debugfs with the same code. Rob did that, I recently converted drm_mm, it's pretty cool.
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c > index 1e1f6b8184d0..3f360cf6cf5a 100644 > --- a/drivers/gpu/drm/vc4/vc4_dpi.c > +++ b/drivers/gpu/drm/vc4/vc4_dpi.c > @@ -144,17 +144,6 @@ static const struct { > DPI_REG(DPI_ID), > }; > > -static void vc4_dpi_dump_regs(struct vc4_dpi *dpi) > -{ > - int i; > - > - for (i = 0; i < ARRAY_SIZE(dpi_regs); i++) { > - DRM_INFO("0x%04x (%s): 0x%08x\n", > - dpi_regs[i].reg, dpi_regs[i].name, > - DPI_READ(dpi_regs[i].reg)); > - } > -} > - > #ifdef CONFIG_DEBUG_FS > int vc4_dpi_debugfs_regs(struct seq_file *m, void *unused) > { > @@ -416,8 +405,6 @@ static int vc4_dpi_bind(struct device *dev, struct device *master, void *data) > if (IS_ERR(dpi->regs)) > return PTR_ERR(dpi->regs); > > - vc4_dpi_dump_regs(dpi); > - > if (DPI_READ(DPI_ID) != DPI_ID_VALUE) { > dev_err(dev, "Port returned 0x%08x for ID instead of 0x%08x\n", > DPI_READ(DPI_ID), DPI_ID_VALUE); > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |