lkml.org 
[lkml]   [2017]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [Xen-devel] [PATCH 3/3] xen/privcmd: add IOCTL_PRIVCMD_RESTRICT
    Date
    > -----Original Message-----
    > From: Jan Beulich [mailto:JBeulich@suse.com]
    > Sent: 09 February 2017 14:43
    > To: Paul Durrant <Paul.Durrant@citrix.com>
    > Cc: xen-devel@lists.xenproject.org; Boris Ostrovsky
    > <boris.ostrovsky@oracle.com>; Juergen Gross <JGross@suse.com>; linux-
    > kernel@vger.kernel.org
    > Subject: Re: [Xen-devel] [PATCH 3/3] xen/privcmd: add
    > IOCTL_PRIVCMD_RESTRICT
    >
    > >>> On 09.02.17 at 15:17, <paul.durrant@citrix.com> wrote:
    > > @@ -666,6 +680,20 @@ static long privcmd_ioctl_dm_op(void __user
    > *udata)
    > > return rc;
    > > }
    > >
    > > +static long privcmd_ioctl_restrict(struct file *file, void __user *udata)
    > > +{
    > > + struct privcmd_data *data = file->private_data;
    > > + domid_t dom;
    > > +
    > > + if (copy_from_user(&dom, udata, sizeof(dom)))
    > > + return -EFAULT;
    > > +
    > > + /* Set restriction to the specified domain */
    > > + data->domid = dom;
    > > +
    > > + return 0;
    > > +}
    >
    > Is it really intended for the caller to be able to undo this, by passing
    > in DOMID_INVALID?

    Good point. I was intending to fix that, but forgot.

    Paul

    >
    > Jan

    \
     
     \ /
      Last update: 2017-02-09 15:49    [W:5.236 / U:1.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site