lkml.org 
[lkml]   [2017]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] platform/x86: intel_pmc_ipc: read s0ix residency API
From
Date
On Thu, 2017-02-09 at 12:17 +0530, Rajneesh Bhardwaj wrote:
> On Mon, Feb 06, 2017 at 05:09:51AM -0800, Shanth Murthy wrote:

> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
 
> > +static int intel_pmc_s0ix_counter_read(u64 *data)
> > +{
> > + return -EINVAL;
> > +}
> > +
>
> How about making it static inline and return -ENOSYS instead of
> -EINVAL?

I'm not sure what's going on.
Your SoB is in this patch and now it feels like you are reviewing this
patch.

What should I do?

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2017-02-09 12:36    [W:0.112 / U:1.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site