Messages in this thread | | | Date | Tue, 07 Feb 2017 13:55:48 -0500 (EST) | Subject | Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Tue, 07 Feb 2017 13:53:12 -0500 (EST)
> From: Stefan Brüns <stefan.bruens@rwth-aachen.de> > Date: Tue, 7 Feb 2017 03:33:16 +0100 > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly different indication message. >> The dual-stack indication omits the link_type (IPv4/v6) and adds >> additional address fields. >> IPv6 LSIs are identical to IPv4 LSIs, but have a different link type. >> >> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > Applied. > > Ignore my earlier comments about the UMTS comment, it is still > accurate of course. :-)
Acutally, this still need work. I had to revert.
You removed the code using the 'eth' variable from sierra_net_bind() but left the unused variable declared.
Please respin this series with it removed so we don't get the warning:
drivers/net/usb/sierra_net.c: In function ‘sierra_net_bind’: drivers/net/usb/sierra_net.c:687:17: warning: unused variable ‘eth’ [-Wunused-variable] struct ethhdr *eth;
| |