lkml.org 
[lkml]   [2017]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info
From
Date


On 2017年02月06日 01:15, Christoph Hellwig wrote:
> We don't really need struct virtio_pci_vq_info, as most field in there
> are redundant:
>
> - the vq backpointer is not strictly neede to start with
> - the entry in the vqs list is not needed - the generic virtqueue already
> has list, we only need to check if it has a callback to get the same
> semantics
> - we can use a simple array to look up the MSI-X vec if needed.
> - That simple array now also duoble serves to replace the per_vq_vectors
> flag
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
> drivers/virtio/virtio_pci_common.c | 117 +++++++++++--------------------------
> drivers/virtio/virtio_pci_common.h | 25 +-------
> drivers/virtio/virtio_pci_legacy.c | 6 +-
> drivers/virtio/virtio_pci_modern.c | 6 +-
> 4 files changed, 39 insertions(+), 115 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index 186cbab327b8..a33767318cbf 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -62,16 +62,13 @@ static irqreturn_t vp_config_changed(int irq, void *opaque)
> static irqreturn_t vp_vring_interrupt(int irq, void *opaque)
> {
> struct virtio_pci_device *vp_dev = opaque;
> - struct virtio_pci_vq_info *info;
> irqreturn_t ret = IRQ_NONE;
> - unsigned long flags;
> + struct virtqueue *vq;
>
> - spin_lock_irqsave(&vp_dev->lock, flags);
> - list_for_each_entry(info, &vp_dev->virtqueues, node) {
> - if (vring_interrupt(irq, info->vq) == IRQ_HANDLED)
> + list_for_each_entry(vq, &vp_dev->vdev.vqs, list) {
> + if (vq->callback && vring_interrupt(irq, vq) == IRQ_HANDLED)
> ret = IRQ_HANDLED;
> }

The check is still there.

Thanks

\
 
 \ /
  Last update: 2017-02-07 08:17    [W:2.275 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site