Messages in this thread | | | Date | Tue, 7 Feb 2017 11:30:01 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] tools/lib/api/fs: Add procfs int read/write helpers |
| |
On Mon, Feb 06, 2017 at 10:43:56PM -0300, Arnaldo Carvalho de Melo wrote: > > int sysctl__read_int(const char *sysctl, int *value); > > Isn't sysctl__read_int() what you want?
Right, so looking at this: don't you think that having both sysctl__* and procfs__* is a little redundant?
The sysctl* things are doing the accesses over proc so shouldn't it all be procfs__* interfaces and no sysctl__* ones at all
or
at least the sysctl__* ones should call the procfs__* ones?
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |