lkml.org 
[lkml]   [2017]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next 1/4] net: mv643xx_eth: Do not clobber PHY link outside of state machine
    Date
    Calling phy_read_status() means that we may call into
    genphy_read_status() which in turn will use genphy_update_link() which
    can make changes to phydev->link outside of the state machine's state
    transitions. This is an invalid behavior that is now caught as of
    811a919135b9 ("phy state machine: failsafe leave invalid RUNNING state")

    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    ---
    drivers/net/ethernet/marvell/mv643xx_eth.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
    index 20cb7f0de601..25642dee49d3 100644
    --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
    +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
    @@ -1504,9 +1504,7 @@ mv643xx_eth_get_link_ksettings_phy(struct mv643xx_eth_private *mp,
    int err;
    u32 supported, advertising;

    - err = phy_read_status(dev->phydev);
    - if (err == 0)
    - err = phy_ethtool_ksettings_get(dev->phydev, cmd);
    + err = phy_ethtool_ksettings_get(dev->phydev, cmd);

    /*
    * The MAC does not support 1000baseT_Half.
    --
    2.9.3
    \
     
     \ /
      Last update: 2017-02-07 00:58    [W:3.145 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site