lkml.org 
[lkml]   [2017]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 01/14] mm: thp: make __split_huge_pmd_locked visible.
    On Sun, Feb 05, 2017 at 11:12:39AM -0500, Zi Yan wrote:
    > +++ b/include/linux/huge_mm.h
    > @@ -120,6 +120,8 @@ static inline int split_huge_page(struct page *page)
    > }
    > void deferred_split_huge_page(struct page *page);
    >
    > +void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
    > + unsigned long haddr, bool freeze);

    Could you change that from 'haddr' to 'address' so callers who only
    read the header instead of the implementation aren't expecting to align
    it themselves?

    > +void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
    > + unsigned long address, bool freeze)
    > {
    > struct mm_struct *mm = vma->vm_mm;
    > struct page *page;

    \
     
     \ /
      Last update: 2017-02-06 16:03    [W:5.217 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site