lkml.org 
[lkml]   [2017]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] staging: lustre: align else if statement to coding standard
From
Date
On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > > - move logical continuations at the end of line
> > > > - move else if statement to a single line
> > > > - Replace spaces with tabstop.
> > >
> > > That's a lot of different things, happening all at once. Please break
> > > this up into multiple patches, each one only doing one thing, and send a
> > > patch series.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Fixing two lines of code in three patches?
>
> Yes.

Greg is also sometimes completely crazy.

I think he's only doing this because you are a
relatively new patch submitter and he wants you
to go through some linux-kernel process hazing.

It'd be more efficient as a single patch and better
overall to avoid descriptions with multiple
characteristics that elicit Greg's somewhat OCD
reflexes.

If this commit log was merely described as "use a
normal kernel style" for the else if and nothing
else was mentioned, this would likely have been
accepted.

\
 
 \ /
  Last update: 2017-02-06 15:50    [W:0.040 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site