lkml.org 
[lkml]   [2017]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 301/319] uio: fix dmem_region_start computation
    Date
    From: Jan Viktorin <viktorin@rehivetech.com>

    commit 4d31a2588ae37a5d0f61f4d956454e9504846aeb upstream.

    The variable i contains a total number of resources (including
    IORESOURCE_IRQ). However, we want the dmem_region_start to point
    after the last resource of type IORESOURCE_MEM. The original behaviour
    leads (very likely) to skipping several UIO mapping regions and makes
    them useless. Fix this by computing dmem_region_start from the uiomem
    which points to the last used UIO mapping.

    Fixes: 0a0c3b5a24bd ("Add new uio device for dynamic memory allocation")

    Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    drivers/uio/uio_dmem_genirq.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
    index 252434c..2290b1f 100644
    --- a/drivers/uio/uio_dmem_genirq.c
    +++ b/drivers/uio/uio_dmem_genirq.c
    @@ -229,7 +229,7 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
    ++uiomem;
    }

    - priv->dmem_region_start = i;
    + priv->dmem_region_start = uiomem - &uioinfo->mem[0];
    priv->num_dmem_regions = pdata->num_dynamic_regions;

    for (i = 0; i < pdata->num_dynamic_regions; ++i) {
    --
    2.8.0.rc2.1.gbe9624a
    \
     
     \ /
      Last update: 2017-02-05 21:02    [W:4.029 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site