Messages in this thread | | | Date | Fri, 3 Feb 2017 09:22:50 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/9] virtio_pci: remove struct virtio_pci_vq_info |
| |
On Fri, Feb 03, 2017 at 03:54:36PM +0800, Jason Wang wrote: >> + list_for_each_entry(vq, &vp_dev->vdev.vqs, list) { >> + if (vq->callback && vring_interrupt(irq, vq) == IRQ_HANDLED) > > The check of vq->callback seems redundant, we will check it soon in > vring_interrupt().
Good point - I wanted to keep things exactly as-is and dіdn't notice we were already protected.
| |