| Date | Fri, 3 Feb 2017 11:33:04 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 10/60] staging: lustre: obdclass: add more info to sysfs version string |
| |
On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote: > From: Andreas Dilger <andreas.dilger@intel.com> > > Update the sysfs "version" file to print "lustre: " with > the version number. > > Signed-off-by: Andreas Dilger <andreas.dilger@intel.com> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5969 > Reviewed-on: http://review.whamcloud.com/16721 > Reviewed-by: James Simmons <uja.ornl@yahoo.com> > Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> > Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> > Signed-off-by: James Simmons <jsimmons@infradead.org> > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > index 9f5e829..22e6d1f 100644 > --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > @@ -208,7 +208,7 @@ struct miscdevice obd_psdev = { > static ssize_t version_show(struct kobject *kobj, struct attribute *attr, > char *buf) > { > - return sprintf(buf, "%s\n", LUSTRE_VERSION_STRING); > + return sprintf(buf, "lustre: %s\n", LUSTRE_VERSION_STRING); > }
Why? You "know" this is lustre, why say it again? Doesn't this affect userspace tools?
thanks,
greg k-h
|