Messages in this thread | | | Subject | Re: [PATCH 3/8] watchdog: wm831x watchdog really needs mfd | From | Randy Dunlap <> | Date | Tue, 28 Feb 2017 18:50:42 -0800 |
| |
On 02/28/17 15:16, Guenter Roeck wrote: > On Tue, Feb 28, 2017 at 10:48:27PM +0100, Arnd Bergmann wrote: >> On Tue, Feb 28, 2017 at 10:44 PM, Arnd Bergmann <arnd@arndb.de> wrote: >>> On Tue, Feb 28, 2017 at 10:36 PM, Guenter Roeck <linux@roeck-us.net> wrote: >>> >>>>> config WM831X_WATCHDOG >>>>> tristate "WM831x watchdog" >>>>> - depends on MFD_WM831X || COMPILE_TEST >>>>> + depends on MFD_WM831X >>>> >>>> I prefer the fix proposed by Randy: >>>> >>>> - depends on MFD_WM831X || COMPILE_TEST >>>> + depends on MFD_WM831X || (MFD_WM831X=y && COMPILE_TEST) >>>> >>> >>> Agreed, that's better. >> >> Actually I misread. They should be completely equivalent, the part after >> the || has no effect here. >> > Yes, I figured that out later as well.
Agreed. Arnd's is simpler. My patch might keep someone else from making the same mistake. ;)
-- ~Randy
| |