Messages in this thread | | | Date | Tue, 28 Feb 2017 20:54:09 +0000 | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH 1/4] MIPS: Handle non word sized instructions when examining frame |
| |
On Tue, 28 Feb 2017, Matt Redfearn wrote:
> Since the instruction modifying the stack pointer is usually the first > in the function, that one is ususally handled correctly. But the
s/ususally/usually/
> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c > index 803e255b6fc3..5b1e932ae973 100644 > --- a/arch/mips/kernel/process.c > +++ b/arch/mips/kernel/process.c > @@ -347,6 +347,7 @@ static int get_frame_info(struct mips_frame_info *info) > union mips_instruction insn, *ip, *ip_end; > const unsigned int max_insns = 128; > unsigned int i; > + unsigned int last_insn_size = 0;
Please keep declarations in the reverse Christmas tree order, i.e. swap the last two.
Maciej
| |