lkml.org 
[lkml]   [2017]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] drm/via: use get_user_pages_unlocked()
On Tue, Feb 28, 2017 at 10:01:10AM +0100, Daniel Vetter wrote:

> > + ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr,
> > + vsg->num_pages, vsg->pages,
> > + (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0);

Umm... Why not
ret = get_user_pages_fast((unsigned long)xfer->mem_addr,
vsg->num_pages,
vsg->direction == DMA_FROM_DEVICE,
vsg->pages);

IOW, do you really need a warranty that ->mmap_sem will be grabbed and
released?

\
 
 \ /
  Last update: 2017-02-28 20:38    [W:0.847 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site