lkml.org 
[lkml]   [2017]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/4] fujitsu_init() cleanup
On Tue, Feb 28, 2017 at 4:01 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote:
>> > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote:
>> > > GregKH wrote:

>> Greg objected to that, arguing that there might be userspace
>> applications using these attributes under their current path. I do not
>> know of such an application. My question to Darren was thus: do we move
>> dock, lid and radios and rip the platform driver and platform device out
>> of fujitsu-laptop or should these attributes rather stay where they are?
>
> I would say just to leave them as-is, there's no harm in those 40 lines,
> and you really don't want to break someone's existing setup for no good
> reason.

Michał, from design point of view you can split it to two parts if
*makes sense* / *needed*: core and platform driver.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-02-28 15:51    [W:1.165 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site