lkml.org 
[lkml]   [2017]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks
From
Date
On Tue, 2017-02-28 at 00:21 +0200, Ruslan Bilovol wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.

> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>

While I think all the defconfigs that have CONFIG_EXPERIMENTAL
should have those lines removed, this seems sensible enough.

$ git grep -w CONFIG_EXPERIMENTAL -- "*defconfig*" | wc -l
216

Acked-by: Joe Perches <joe@perches.com>

Here's a little script to remove the CONFIG_EXPERIMENTAL
lines from all the defconfigs too:

$ git grep -w --name-only CONFIG_EXPERIMENTAL -- "*defconfig*" | \
xargs sed -i -e '/CONFIG_EXPERIMENTAL=[yn]/d'

> ---
> scripts/checkpatch.pl | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 982c52c..e0a34e6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2746,13 +2746,6 @@ sub process {
> #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
> }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
> - if ($realfile =~ /Kconfig/ &&
> - $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
> - WARN("CONFIG_EXPERIMENTAL",
> - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> - }
> -
> # discourage the use of boolean for type definition attributes of Kconfig options
> if ($realfile =~ /Kconfig/ &&
> $line =~ /^\+\s*\bboolean\b/) {
> @@ -3146,12 +3139,6 @@ sub process {
> }
> }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
> - if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
> - WARN("CONFIG_EXPERIMENTAL",
> - "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> - }
> -
> # check for RCS/CVS revision markers
> if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
> WARN("CVS_KEYWORD",

\
 
 \ /
  Last update: 2017-02-28 00:44    [W:0.051 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site