lkml.org 
[lkml]   [2017]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks
    On Mon, Feb 27, 2017 at 10:28:17AM +0100, Michal Hocko wrote: 
    >diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
    >index 134a2f69c21a..a72f7f64ee26 100644
    >--- a/include/linux/memory_hotplug.h
    >+++ b/include/linux/memory_hotplug.h
    >@@ -100,8 +100,6 @@ extern void __online_page_free(struct page *page);
    >
    > extern int try_online_node(int nid);
    >
    >-extern bool memhp_auto_online;
    >-
    > #ifdef CONFIG_MEMORY_HOTREMOVE
    > extern bool is_pageblock_removable_nolock(struct page *page);
    > extern int arch_remove_memory(u64 start, u64 size);
    >@@ -272,7 +270,7 @@ static inline void remove_memory(int nid, u64 start, u64 size) {}
    >
    > extern int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
    > void *arg, int (*func)(struct memory_block *, void *));
    >-extern int add_memory(int nid, u64 start, u64 size);
    >+extern int add_memory(int nid, u64 start, u64 size, bool online);
    > extern int add_memory_resource(int nid, struct resource *resource, bool online);
    > extern int zone_for_memory(int nid, u64 start, u64 size, int zone_default,
    > bool for_device);

    It would be nice if instead of a 'bool online' argument, add_memory()
    and add_memory_resource() took an 'int online_type', ala online_pages().

    That way we could specify offline, online, online+movable, etc.

    --
    Reza Arbab

    \
     
     \ /
      Last update: 2017-02-28 00:33    [W:4.110 / U:1.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site