Messages in this thread | | | Date | Mon, 27 Feb 2017 23:48:13 +0100 | From | Alban <> | Subject | Re: [PATCH 3/3] ath9k: ahb: Add OF support |
| |
On Mon, 27 Feb 2017 22:13:21 +0100 Rafał Miłecki <zajec5@gmail.com> wrote:
> Why you didn't cc linux-wireless?!?!
I first wanted to be sure that the devdata part was generally acceptable, this patch was just included as an example of a user. But it sound like that part will have to move to nvmem first. I'll come back with a new patch once MTD support for nvmem is done.
> On 27 February 2017 at 21:28, Alban <albeu@free.fr> wrote: > > @@ -513,6 +515,43 @@ static void ath9k_eeprom_release(struct ath_softc *sc) > > release_firmware(sc->sc_ah->eeprom_blob); > > } > > > > +#ifdef CONFIG_OF > > +static int ath9k_init_of(struct ath_softc *sc) > > +{ > > + struct device_node *np = sc->dev->of_node; > > + struct ath_hw *ah = sc->sc_ah; > > + const void *macaddr; > > + struct clk *clk; > > + int ret = 0; > > + > > + if (!np) { > > + dev_err(sc->dev, "no platform data or OF node\n"); > > + return -EINVAL; > > + } > > + > > + clk = clk_get(sc->dev, "ref"); > > + if (!IS_ERR(clk)) { > > + ah->is_clk_25mhz = (clk_get_rate(clk) == 25000000); > > + clk_put(clk); > > + } > > + > > + ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz"); > > + ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz"); > > Please use ieee80211-freq-limit: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b330b25eaabda00d74e47566d9200907da381896 > > Most likely with the wiphy_read_of_freq_limits helper: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e691ac2f75b69bee743f0370d79454ba4429b17 > > Example: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0f83ff69735651cc7a3d150466a5257ff829b62b
Thanks, I'll check this.
Alban [unhandled content-type:application/pgp-signature] | |