lkml.org 
[lkml]   [2017]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver
On Mon, Feb 27, 2017 at 11:38 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non
> upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal
> version which implements just enough to get ACPI PMIC opregion support to
> work, so that suspend/resume will work on machines with this PMIC.
>
> Cc: Bin Gao <bin.gao@intel.com>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:

You were too fast. Please, give a time for reviewers to do their job.

So, please address comments per v2 first.

> -Since this uses plain mfd and not the intel_soc_pmic stuff give it
> its own Kconfig and allow this to be built as a module

> -Add missing #include <acpi/acpi_bus.h>

Do we need it explicitly included?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-02-27 23:16    [W:0.047 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site