lkml.org 
[lkml]   [2017]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers
On Mon 27-02-17 09:01:09, Tahsin Erdogan wrote:
> On Mon, Feb 27, 2017 at 7:25 AM, Michal Hocko <mhocko@kernel.org> wrote:
> > /*
> > * No space left. Create a new chunk. We don't want multiple
> > * tasks to create chunks simultaneously. Serialize and create iff
> > * there's still no empty chunk after grabbing the mutex.
> > */
> > if (is_atomic)
> > goto fail;
> >
> > right before pcpu_populate_chunk so is this actually a problem?
>
> Yes, this prevents adding more pcpu chunks and so cause "atomic" allocations
> to fail more easily.

Then I fail to see what is the problem you are trying to fix.

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-02-27 18:08    [W:0.128 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site