Messages in this thread | | | Date | Mon, 27 Feb 2017 15:22:47 +0100 | From | Greg KH <> | Subject | Re: [PATCH 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix |
| |
On Sun, Feb 26, 2017 at 03:32:08PM +1300, Derek Robson wrote: > Fixed style of block comments > Found using checkpatch > > Signed-off-by: Derek Robson <robsonde@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 32 +++++++++++++++--------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h > index 1102451a733d..c99a6dbae476 100644 > --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h > +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h > @@ -162,26 +162,26 @@ static const struct oid_obj_priv oid_rtl_seg_81_80_00[] = { > */ > {1, oid_rt_pro_set_channel_direct_call_hdl}, /*0x08*/ > {1, oid_null_function}, /*0x09 > - * OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL > - */ > + * OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL > + */ > {1, oid_null_function}, /*0x0A > - * OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL > - */ > + * OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL > + */ > {1, oid_rt_pro_set_continuous_tx_hdl}, /*0x0B > - * OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL > - */ > + * OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL
Now you are going out beyond 80 columns, which is what caused someone to move the comment to the left earlier :(
Just put the comment in a single line, above the data definition, like this: /* 0x0B OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL */ {1, oid_rt_pro_set_continuous_tx_hdl},
Which makes it easier for everyone to read and understand, which is the main goal of cleaning up code.
thanks,
greg k-h
| |