Messages in this thread | | | Date | Mon, 27 Feb 2017 08:29:48 -0600 | From | Rob Herring <> | Subject | Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution |
| |
On Fri, Feb 24, 2017 at 05:04:45PM +0100, Fabrice Gasnier wrote: > On 02/19/2017 01:09 PM, Jonathan Cameron wrote: > > On 15/02/17 16:55, Fabrice Gasnier wrote: > > > Add documentation for 'st,adc-res' dt optional property. > > > > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com> > > I'm happy with this, but would like to leave time for a device tree review. > > > > Ultimately we may well want to make this a generic property and call it something > > like adc-resolution but perhaps we need to wait until we have a few more devices > > supporting setting it via device tree to figure out what the best interface is. > > It would exactly be a problem to support this as a deprecated binding at that > > point. > > Hi Jonathan, > > I agree with you on this... It may be better to have generic property > for this, especially if you see that it will come in the near future. > May I suggest this prop to be less restrictive, e.g. like resolution-bits as > is may also be worth for other device types, e.g. DAC as an example ?
Yes, please make this a commmon property.
Rob
| |