lkml.org 
[lkml]   [2017]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] scsi: aacraid: remove redundant zero check on ret
Date
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Friday, February 24, 2017 7:44 AM
> To: dl-esc-Aacraid Linux Driver; James E . J . Bottomley; Martin K .
> Petersen; linux-scsi@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] scsi: aacraid: remove redundant zero check on ret
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The check for ret being zero is redundant as a few statements earlier we
> break out of the while loop if ret is non-zero. Thus we can remove the
> zero check and also the dead-code non-zero case too.
>
> Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/aacraid/commsup.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Dave Carroll <david.carroll@microsemi.com>
\
 
 \ /
  Last update: 2017-02-26 21:39    [W:0.049 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site