lkml.org 
[lkml]   [2017]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches
Date
Hi Dmitry,

On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> The OF device table must be terminated, otherwise we'll be walking past
> it and into areas unknown.
>
> This causes KASAN errors reported by 0day kernel testing robot.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> ASCII...") Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through
the MIPS tree perhaps this fix can too?

Thanks,
Paul

> ---
> drivers/auxdisplay/img-ascii-lcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c
> b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d2aafc..83f1439e57fd
> 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[]
> = { { .compatible = "img,boston-lcd", .data = &boston_config },
> { .compatible = "mti,malta-lcd", .data = &malta_config },
> { .compatible = "mti,sead3-lcd", .data = &sead3_config },
> + { /* sentinel */ }
> };
>
> /**

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-02-24 22:58    [W:0.059 / U:23.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site