lkml.org 
[lkml]   [2017]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access
    On Thu, Feb 23, 2017 at 06:27:52PM +0200, Andy Shevchenko wrote:
    > On Wed, Feb 22, 2017 at 12:22 PM, Eva Rachel Retuya <eraretuya@gmail.com> wrote:
    > > Convert the driver to use regmap instead of I2C-specific functions.
    > > Also, introduce the header file "adxl345.h" and export the probe and
    > > remove functions. This is done in preparation for splitting this driver
    > > into core and I2C-specific code as well as introduction of SPI driver.
    > >
    > > Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
    >
    > Is it possible to use device just after this very patch?
    > For me it seems there is bisectability issue.
    >

    Hello Andy,

    Most likely no because of excessive deletion. Sorry for the mistake, I'll
    submit another version that hopefully won't cause this issue.

    Thanks,
    Eva

    > > -static const struct i2c_device_id adxl345_i2c_id[] = {
    > > - { "adxl345", 0 },
    > > - { }
    > > -};
    > > -
    > > -MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
    > > -
    > > -static struct i2c_driver adxl345_driver = {
    > > - .driver = {
    > > - .name = "adxl345",
    > > - },
    > > - .probe = adxl345_probe,
    > > - .remove = adxl345_remove,
    > > - .id_table = adxl345_i2c_id,
    > > -};
    > > -
    > > -module_i2c_driver(adxl345_driver);
    > > +EXPORT_SYMBOL_GPL(adxl345_common_remove);
    >
    > --
    > With Best Regards,
    > Andy Shevchenko

    \
     
     \ /
      Last update: 2017-02-24 10:04    [W:3.043 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site