lkml.org 
[lkml]   [2017]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high
On Fri, Feb 17, 2017 at 10:12 AM, Phil Reid <preid@electromag.com.au> wrote:

> ret = gpiochip_irqchip_add(&altera_gc->mmchip.gc, &altera_irq_chip, 0,
> - handle_simple_irq, IRQ_TYPE_NONE);
> + altera_gc->interrupt_trigger == IRQ_TYPE_LEVEL_HIGH ?
> + handle_level_irq : handle_simple_irq, IRQ_TYPE_NONE);

I would say: set it to handle_bad_irq() for everything and then set it
to handle_level_irq() or handle_simple_irq() in the .set_type() function
using the rq_set_handler_locked() callback like everyone else,
nicely reflecting the synthesized trigger type.

I think that would work?

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-02-23 15:55    [W:1.486 / U:26.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site