Messages in this thread | | | Date | Wed, 22 Feb 2017 14:46:33 -0500 | From | Paul Gortmaker <> | Subject | Re: [PATCH] score: Add missing include files |
| |
[[PATCH] score: Add missing include files] On 22/02/2017 (Wed 11:07) Guenter Roeck wrote:
> Kernel builds fail with > > arch/score/kernel/traps.c: In function 'do_ri': > arch/score/kernel/traps.c:248:4: error: > implicit declaration of function 'user_disable_single_step' > arch/score/mm/extable.c: In function 'fixup_exception': > arch/score/mm/extable.c:32:38: error: > dereferencing pointer to incomplete type > arch/score/mm/extable.c:34:24: error: > dereferencing pointer to incomplete type > > Fixes: 0f296af85be8 ("score: migrate exception table users off ...")
Not surprising, neither me/korg[1] nor kbuild nor linux-next have score tc for build coverage, so score got the "this looks right" treatment.
Too bad your coverage didn't use linux-next over the last couple weeks, as then it could have been in the pull request I'd just sent. Oh well.
Mind if I ask where you got your toolchain? I'm not in a position to futz around trying to build one myself for some of these less common architectures, but I'm not against extending my coverage using existing toolchains.
[1] https://www.kernel.org/pub/tools/crosstool/
Thanks, Paul. --
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > arch/score/kernel/traps.c | 1 + > arch/score/mm/extable.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/arch/score/kernel/traps.c b/arch/score/kernel/traps.c > index 2b22bcf02c27..d0634cb6127f 100644 > --- a/arch/score/kernel/traps.c > +++ b/arch/score/kernel/traps.c > @@ -24,6 +24,7 @@ > */ > > #include <linux/extable.h> > +#include <linux/ptrace.h> > #include <linux/sched.h> > > #include <asm/cacheflush.h> > diff --git a/arch/score/mm/extable.c b/arch/score/mm/extable.c > index ec871355fc2d..6736a3ad6286 100644 > --- a/arch/score/mm/extable.c > +++ b/arch/score/mm/extable.c > @@ -24,6 +24,8 @@ > */ > > #include <linux/extable.h> > +#include <linux/ptrace.h> > +#include <asm/extable.h> > > int fixup_exception(struct pt_regs *regs) > { > -- > 2.7.4 >
| |