Messages in this thread | | | Subject | Re: [PATCH v2 1/2] usbip: Fix-format-overflow | From | Jonathan Dieter <> | Date | Wed, 22 Feb 2017 20:14:25 +0200 |
| |
On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote: > Hi, > > W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze: <snip> > > char busid[SYSFS_BUS_ID_SIZE]; > > + unsigned int size; > > I'm not really convinced to use unsigned here. snprintf() is declared > to > return signed integer so we should assume that some of its > implementation may return negative error code. Any rationale to this > instead of just doing a cast for comparsion but signed value to print > error?
No, you're absolutely right. I've fixed this and am sending the next revision now.
Jonathan
| |