Messages in this thread | | | Subject | Re: [PATCH 1/4] perf annotate: Remove needless regular expression for filename:linenr | From | Taeung Song <> | Date | Thu, 23 Feb 2017 01:00:59 +0900 |
| |
Hi Namhyung,
On 02/22/2017 07:47 PM, Namhyung Kim wrote: > Hi Taeung, > > On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.taeung@gmail.com> wrote: >> The commit e592488c01d5 ("perf annotate: Support source line >> numbers in annotate") support source line numbers in annotate. >> >> But we can get filename:line number by symbol__get_source_line() >> Furthermore, the way can't exactly match source code lines >> to actual line numbers. >> >> For example, >> Actual source code is as below >> >> ... >> 21 }; >> 22 >> 23 unsigned int limited_wgt; >> 24 >> 25 unsigned int get_cond_maxprice(int wgt) >> 26 { >> ... >> >> However, the output of annotate with the way about regmatch >> is as below. >> >> 4 Disassembly of section .text: >> >> 6 0000000000400966 <get_cond_maxprice>: >> 7 get_cond_maxprice(): >> 26 }; >> >> 28 unsigned int limited_wgt; >> >> 30 unsigned int get_cond_maxprice(int wgt) >> 31 { >> >> The root cause is from objdump -S. >> Because the source code of objdump used to print more code lines >> than actual one code line according to a particular line number. >> In the near future, I'll fix the problem about line numbers. > > So what's the purpose of this patch? You just removed the line > number from the output, it changed behavior for what? If you want > to fix a problem of line number, please do it here.. > > Thanks, > Namhyung > >
The purpose of this patch was to remove needless code about line number. To avoid big size of commit, I made several patches as parts..
But as you said I also think it is better to remake this patch preferentially centering important points of the patchset!
Thanks Taeung
| |