lkml.org 
[lkml]   [2017]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 8/9] sched: Don't reinvent the wheel but use existing llist API
    On Tue, Feb 14, 2017 at 04:26:29PM +0900, Byungchul Park wrote:
    > Although llist provides proper APIs, they are not used. Make them used.

    Hello,

    What do you think?

    >
    > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
    > ---
    > kernel/sched/core.c | 15 +++------------
    > 1 file changed, 3 insertions(+), 12 deletions(-)
    >
    > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    > index d01f9d0..8938125 100644
    > --- a/kernel/sched/core.c
    > +++ b/kernel/sched/core.c
    > @@ -1773,7 +1773,7 @@ void sched_ttwu_pending(void)
    > {
    > struct rq *rq = this_rq();
    > struct llist_node *llist = llist_del_all(&rq->wake_list);
    > - struct task_struct *p;
    > + struct task_struct *p, *t;
    > unsigned long flags;
    > struct rq_flags rf;
    >
    > @@ -1783,17 +1783,8 @@ void sched_ttwu_pending(void)
    > raw_spin_lock_irqsave(&rq->lock, flags);
    > rq_pin_lock(rq, &rf);
    >
    > - while (llist) {
    > - int wake_flags = 0;
    > -
    > - p = llist_entry(llist, struct task_struct, wake_entry);
    > - llist = llist_next(llist);
    > -
    > - if (p->sched_remote_wakeup)
    > - wake_flags = WF_MIGRATED;
    > -
    > - ttwu_do_activate(rq, p, wake_flags, &rf);
    > - }
    > + llist_for_each_entry_safe(p, t, llist, wake_entry)
    > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf);
    >
    > rq_unpin_lock(rq, &rf);
    > raw_spin_unlock_irqrestore(&rq->lock, flags);
    > --
    > 1.9.1

    \
     
     \ /
      Last update: 2017-02-22 06:05    [W:4.433 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site