Messages in this thread | | | Subject | Re: [Outreachy kernel] [PATCH v2 2/7] staging: most: Using macro DIV_ROUND_UP | From | Joe Perches <> | Date | Wed, 22 Feb 2017 02:07:55 -0800 |
| |
On Wed, 2017-02-22 at 10:27 +0100, Julia Lawall wrote: > > @@ -117,7 +118,7 @@ static int alloc_dbr(u16 size) > > return DBR_SIZE; /* out of memory */ > > > > for (i = 0; i < DBR_MAP_SIZE; i++) { > > - u32 const blocks = (size + DBR_BLOCK_SIZE - 1) / DBR_BLOCK_SIZE; > > + u32 const blocks = DIV_ROUND_UP(size, DBR_BLOCK_SIZE); > > u32 mask = ~((~(u32)0) << blocks); > > Totally unrelated to DIV_ROUND_UP, would this code be a candidate for > GENMASK?
Maybe "(1 << blocks) - 1" would be more intelligible.
| |