Messages in this thread | | | Subject | Re: [PATCH v9 1/2] Add OV5647 device tree documentation | From | Ramiro Oliveira <> | Date | Tue, 21 Feb 2017 20:13:16 +0000 |
| |
Hi Vladimir,
Thank you for your feedback
On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: > Hi Ramiro, > > On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >> Create device tree bindings documentation. >> >> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt >> new file mode 100644 >> index 000000000000..31956426d3b9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt >> @@ -0,0 +1,35 @@ >> +Omnivision OV5647 raw image sensor >> +--------------------------------- >> + >> +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces >> +and CCI (I2C compatible) control bus. >> + >> +Required properties: >> + >> +- compatible : "ovti,ov5647". >> +- reg : I2C slave address of the sensor. >> +- clocks : Reference to the xclk clock. > > Is "xclk" clock a pixel clock or something else? >
It's an external oscillator.
>> +- clock-names : Should be "xclk". > > You can remove this property, because there is only one source clock. >
Ok.
>> +- clock-frequency : Frequency of the xclk clock. > > And after the last updates in the driver this property can be removed as well. >
But I'm still using clk_get_rate in the driver, if I remove the frequency here the probing will fail.
>> + >> +The common video interfaces bindings (see video-interfaces.txt) should be >> +used to specify link to the image data receiver. The OV5647 device >> +node should contain one 'port' child node with an 'endpoint' subnode. >> + >> +Example: >> + >> + i2c@2000 { >> + ... >> + ov: camera@36 { >> + compatible = "ovti,ov5647"; >> + reg = <0x36>; >> + clocks = <&camera_clk>; >> + clock-names = "xclk"; >> + clock-frequency = <25000000>; > > When you remove two unused properties, please don't forget to update the > example. >
Ok.
>> + port { >> + camera_1: endpoint { >> + remote-endpoint = <&csi1_ep1>; >> + }; >> + }; >> + }; >> + }; >> > > -- > With best wishes, > Vladimir >
-- Best Regards
Ramiro Oliveira Ramiro.Oliveira@synopsys.com
| |