Messages in this thread | | | Subject | Re: [PATCH] iio: adc: xilinx: Fix error handling | From | Lars-Peter Clausen <> | Date | Mon, 20 Feb 2017 09:35:04 +0100 |
| |
On 02/19/2017 09:29 PM, Christophe JAILLET wrote: > Reorder error handling labels in order to match the way resources have > been allocated. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, looks good.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
I think there is one more issue
ret = xadc->ops->setup(pdev, indio_dev, irq); if (ret) goto err_free_samplerate_trigger;
should be
goto err_clk_disable_unprepare;
| |